Mention lnd's SCB feature in the corresponding error message #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit confusing when we see only "Peer sent a garbage channel_reestablish" when a peer uses lnd's SCB feature to ask us to broadcast the latest state. This updates the error message to be a bit clearer.
wpaulino
approved these changes
May 5, 2023
tnull
approved these changes
May 5, 2023
benthecarman
reviewed
May 5, 2023
|
I'm not sure that others use the same error message, though, or at least I've never had a CLN/eclair node fail with an emergency hope-and-pray backup so I have no idea(I forget what the others call them but that's definitely what it should be lol). |
|
Treating the emoji response from @benthecarman as "dunno either, no need to update the message text". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit confusing when we see only "Peer sent a garbage channel_reestablish" when a peer uses lnd's SCB feature to ask us to broadcast the latest state. This updates the error message to be a bit clearer.