Drop create_inbound_payment*_legacy breaking downgrade to 0.0.103
#2351
Conversation
|
There is also the deprecated (6, 0u64, required), // user_payment_id required for compatibility with 0.0.103 and earlier |
0.0.103 is now downright ancient, and certainly shouldn't exist in production anywhere today. Thus, it seems fine to remove the ability to create legacy stateful inbound payment entries. Users downgrading to 0.0.103 will thus not be able to claim any payments created on modern LDK, though we still retain the ability to claim such payments at least for one more release.
TheBlueMatt
force-pushed
the
2023-04-remove-legacy-recv
branch
from
70c0802 to
34772ca
Compare
Sure! |
Nice! Could modify the note on the read side to include when we stopped writing the field, so that we can stop reading it someday, too. |
Since we're breaking downgrade compatibility to LDK version 0.0.103 and before, we might as well go ahead and remove other code we have for compatibility.
TheBlueMatt
force-pushed
the
2023-04-remove-legacy-recv
branch
from
34772ca to
942d776
Compare
|
Done. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
==========================================
- Coverage 90.48% 90.45% -0.04%
==========================================
Files 104 104
Lines 53920 53858 -62
Branches 53920 53858 -62
==========================================
- Hits 48790 48717 -73
- Misses 5130 5141 +11
☔ View full report in Codecov by Sentry. |
0.0.103 is now downright ancient, and certainly shouldn't exist in production anywhere today. Thus, it seems fine to remove the ability to create legacy stateful inbound payment entries.
Users downgrading to 0.0.103 will thus not be able to claim any payments created on modern LDK, though we still retain the ability to claim such payments at least for one more release.