Update send_payment_along_path to take its args as struct
#2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up and paves the way for additional arguments to be added more easily, specifically an update_add_htlc's blinding point.
valentinewallace
force-pushed
the
2023-06-send-along-path-args
branch
from
f034fac to
80f904c
Compare
There was a problem hiding this comment.
Code review ACK 80f904c. It definitely makes the code cleaner.
dunxen
approved these changes
Jun 27, 2023
henghonglee
reviewed
Jun 28, 2023
| @@ -473,6 +473,18 @@ impl RecipientOnionFields { | |||
| } | |||
| } | |||
|
|
|||
| /// Arguments for [`super::channelmanager::ChannelManager::send_payment_along_path`]. | |||
| pub(super) struct SendAlongPathArgs<'a> { | |||
There was a problem hiding this comment.
nit: Not so sure about the location of this struct. i'd think its supposed to be more co-located with where its used but i also think channelmanager.rs is also too large.
what is the current understanding around outbound_payment.rs? are we intending to move most/all outbound payment / routing / orchestration logic here?
There was a problem hiding this comment.
The outbound_payment module came about so we could remove code from channelmanager. So, anything exclusive to outbound payments (such as this struct) could reasonably live there IMO. I believe we've moved most if not all of it already.
alecchendev
approved these changes
Jun 29, 2023
valentinewallace
added
the
blocked on next release
valentinewallace
removed
the
blocked on next release
TheBlueMatt
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up and paves the way for additional arguments to be added more easily.
Edit: I thought this was helpful for route blinding, but it actually isn't. Still, I think it's a nice cleanup, so I'll keep it open.