Fix build warnings

[arik-so]

• Fix warning about legacy deserialization prevention markers
• Fix warning about public keys from hex
• Fix warning about dummy HTLCSource type

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d327c23) 90.32% compared to head (89aa7ac) 90.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         106      106           
  Lines       54948    54948           
  Branches    54948    54948           
=======================================
  Hits        49630    49630           
  Misses       5318     5318           

Impacted Files	Coverage Δ
lightning/src/chain/package.rs	91.43% <ø> (ø)
lightning/src/ln/chan_utils.rs	94.51% <ø> (ø)
lightning/src/ln/channel.rs	89.42% <ø> (ø)
lightning/src/ln/channelmanager.rs	86.26% <ø> (ø)
lightning/src/ln/reload_tests.rs	95.81% <100.00%> (ø)
lightning/src/routing/router.rs	93.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[wpaulino]

Thanks! Could we also fix these while we're at it?

warning: variable does not need to be mutable
   --> lightning/src/routing/router.rs:420:9
    |
420 |             for (mut path, blinded_tail_opt) in paths.iter_mut().zip(blinded_tails.into_iter()) {
    |                  ----^^^^
    |                  |
    |                  help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
    --> lightning/src/routing/router.rs:1224:8
     |
1224 |             let mut cur_hop = &mut self.hops.get_mut(i).unwrap().0;
     |                 ----^^^^^^^
     |                 |
     |                 help: remove this `mut`

warning: using `.clone()` on a double reference, which returns `&dyn BroadcasterInterface` instead of cloning the inner type
   --> lightning/src/ln/reload_tests.rs:387:108
    |
387 |     new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);

[arik-so]

Oh yeah, let's fix those other two. Interestingly, they actually did not show up last night in my build.

[arik-so]

I'll think about how to fix the one in line 387.

[arik-so]

I'm not getting that warning about the clone. Which rust version are you using?

[TheBlueMatt]

cargo test --no-default-features --features _test_vectors no longer builds due to public_from_secret_hex not being found. While you're at it can you add a CI step to test that?

[TheBlueMatt]

Oops, nvm I'm blind