Remove doc specifying future anchor support #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
+ Coverage 90.32% 90.59% +0.27%
==========================================
Files 106 106
Lines 54948 56882 +1934
Branches 54948 56882 +1934
==========================================
+ Hits 49630 51534 +1904
- Misses 5318 5348 +30
☔ View full report in Codecov by Sentry. |
|
Good catch. Can you link to the config option to turn on anchors and say that its not generated if that option isnt on? |
AnthonyRonning
force-pushed
the
remove-doc-future-anchor-support
branch
2 times, most recently
from
471ca99 to
eeb06a3
Compare
Added. Let me know if there's any nits there. |
TheBlueMatt
reviewed
Jun 30, 2023
AnthonyRonning
force-pushed
the
remove-doc-future-anchor-support
branch
from
eeb06a3 to
5cc625e
Compare
wpaulino
approved these changes
Jun 30, 2023
TheBlueMatt
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's fully supported now as of this next release, right? Just came across this comment.