Skip to content

Fix 1.54- builds with the backtrace feature due to MSRV breakage #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

TheBlueMatt
Copy link
Collaborator

The test-only backtrace feature broke on rustc prior to 1.55.

The test-only `backtrace` feature broke on rustc prior to 1.55.
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ab80fcf) 90.32% compared to head (6bbe1a4) 90.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         106      106           
  Lines       54965    54965           
  Branches    54965    54965           
=======================================
  Hits        49648    49648           
  Misses       5317     5317           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed so LGTM

@wpaulino wpaulino merged commit c0ea31e into lightningdevkit:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants