-
Notifications
You must be signed in to change notification settings - Fork 407
Release 0.0.116 #2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBlueMatt
merged 3 commits into
lightningdevkit:main
from
TheBlueMatt:2023-07-cut-116
Jul 21, 2023
Merged
Release 0.0.116 #2427
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [package] | ||
| name = "lightning-background-processor" | ||
| version = "0.0.116-rc1" | ||
| version = "0.0.116" | ||
| authors = ["Valentine Wallace <[email protected]>"] | ||
| license = "MIT OR Apache-2.0" | ||
| repository = "http://github.com/lightningdevkit/rust-lightning" | ||
|
|
@@ -15,17 +15,18 @@ rustdoc-args = ["--cfg", "docsrs"] | |
|
|
||
| [features] | ||
| futures = [ ] | ||
| std = ["lightning/std", "lightning-rapid-gossip-sync/std"] | ||
| std = ["bitcoin/std", "lightning/std", "lightning-rapid-gossip-sync/std"] | ||
| no-std = ["bitcoin/no-std", "lightning/no-std", "lightning-rapid-gossip-sync/no-std"] | ||
|
|
||
| default = ["std"] | ||
|
|
||
| [dependencies] | ||
| bitcoin = { version = "0.29.0", default-features = false } | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", default-features = false } | ||
| lightning-rapid-gossip-sync = { version = "0.0.116-rc1", path = "../lightning-rapid-gossip-sync", default-features = false } | ||
| lightning = { version = "0.0.116", path = "../lightning", default-features = false } | ||
| lightning-rapid-gossip-sync = { version = "0.0.116", path = "../lightning-rapid-gossip-sync", default-features = false } | ||
|
|
||
| [dev-dependencies] | ||
| tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] } | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", features = ["_test_utils"] } | ||
| lightning-invoice = { version = "0.24.0-rc1", path = "../lightning-invoice" } | ||
| lightning-persister = { version = "0.0.116-rc1", path = "../lightning-persister" } | ||
| lightning = { version = "0.0.116", path = "../lightning", features = ["_test_utils"] } | ||
| lightning-invoice = { version = "0.24.0", path = "../lightning-invoice" } | ||
| lightning-persister = { version = "0.0.116", path = "../lightning-persister" } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| [package] | ||
| name = "lightning-invoice" | ||
| description = "Data structures to parse and serialize BOLT11 lightning invoices" | ||
| version = "0.24.0-rc1" | ||
| version = "0.24.0" | ||
| authors = ["Sebastian Geisler <[email protected]>"] | ||
| documentation = "https://docs.rs/lightning-invoice/" | ||
| license = "MIT OR Apache-2.0" | ||
|
|
@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"] | |
|
|
||
| [dependencies] | ||
| bech32 = { version = "0.9.0", default-features = false } | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", default-features = false } | ||
| lightning = { version = "0.0.116", path = "../lightning", default-features = false } | ||
| secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] } | ||
| num-traits = { version = "0.2.8", default-features = false } | ||
| bitcoin_hashes = { version = "0.11", default-features = false } | ||
|
|
@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true } | |
| bitcoin = { version = "0.29.0", default-features = false } | ||
|
|
||
| [dev-dependencies] | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", default-features = false, features = ["_test_utils"] } | ||
| lightning = { version = "0.0.116", path = "../lightning", default-features = false, features = ["_test_utils"] } | ||
| hex = "0.4" | ||
| serde_json = { version = "1"} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [package] | ||
| name = "lightning-rapid-gossip-sync" | ||
| version = "0.0.116-rc1" | ||
| version = "0.0.116" | ||
| authors = ["Arik Sosman <[email protected]>"] | ||
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/lightningdevkit/rust-lightning" | ||
|
|
@@ -15,11 +15,11 @@ no-std = ["lightning/no-std"] | |
| std = ["lightning/std"] | ||
|
|
||
| [dependencies] | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", default-features = false } | ||
| lightning = { version = "0.0.116", path = "../lightning", default-features = false } | ||
| bitcoin = { version = "0.29.0", default-features = false } | ||
|
|
||
| [target.'cfg(ldk_bench)'.dependencies] | ||
| criterion = { version = "0.4", optional = true, default-features = false } | ||
|
|
||
| [dev-dependencies] | ||
| lightning = { version = "0.0.116-rc1", path = "../lightning", features = ["_test_utils"] } | ||
| lightning = { version = "0.0.116", path = "../lightning", features = ["_test_utils"] } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so who is going to use anchor outputs with 0.0.116,
ldk-node? i’ve looked aroundnegotiate_anchors_zero_fee_htlc_txand ourCoinSelectionSource, we don’t really have documentation about how to manage fee-bumping reserves, what do you think if I write some simple, conservative and over-collateralized docs for the lightningdevkit website, or do we prefer security-related doc to be under the git tree ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're not going to include it as code documentation, we should at least reference to it somewhere. Happy to have you write something if you wish, I'm also working on a post for the LDK blog introducing anchor outputs and what things one should look out for while implementing it as a LDK user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think the docs are insufficient we should absolutely include them in the struct/config docs. I think many downstream users will use anchor in 116, both large custodial nodes but also ldk-node and ldk-sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to review the post for the LDK blog introducing anchor outputs when it’s ready (don’t hesitate to tag me on it). I’ll go to write more documentation, and I think it’s more appropriate to have them on the website (even if I know long-term it’s more maintenance work), as the very least we start to have a multitude of LDK deployment (mobile / large nodes / standard wallet) and generic documentation on fee-bumping reserves might be better suited here.
@ConorOkus Happy to have your thinking here, as you might have more visibility on downstream users, and if operational and safety documentation should go on the website or in struct/config docs, what is the best way to convey important information to the LDK users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, many of our downstream developers don't ever read the website. If documentation is only on the website I think ~everyone is going to miss it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to release 0.0.116 tomorrow. If you have any further documentation changes you'd like to see happen, we should make sure it happens by tomorrow early morning US time, at the very latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll go for a
doc/fee-bumping-reserve.mda la Linux and it can be copy-paste on the website if we wanna more docs there. Please go to land 0.0.116, I'll add them a posteriori during early 0.0.117 cycle.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you go #2450