Publicize UnsignedChannelAnnouncement's excess_data. #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 106 106
Lines 55691 55691
Branches 55691 55691
=======================================
Hits 50271 50271
Misses 5420 5420
☔ View full report in Codecov by Sentry. |
|
Why does this make the tests simpler? If it's just because it allows constructing, maybe we should just add a constructor? |
|
Ugh I guess these messages are basically POD (well, okay, with vecs lol), we can just expose it. |
TheBlueMatt
approved these changes
Jul 20, 2023
Making the `excess_data` field public significantly simplifies writing legible unit tests for the Rapid Gossip Sync Server.
arik-so
force-pushed
the
2023-07-public-excess-data
branch
from
ce106c0 to
b28769b
Compare
wpaulino
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the
excess_datafield public significantly simplifies writing legible unit tests for the Rapid Gossip Sync Server.