0.0.116 Bindings Changes #2434
Merged
0.0.116 Bindings Changes #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.02%
==========================================
Files 106 106
Lines 55774 55784 +10
Branches 55774 55784 +10
==========================================
Hits 50334 50334
- Misses 5440 5450 +10
☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2023-07-116-bindings-part-2
branch
from
33bda73 to
f23dbd1
Compare
In bindings we can't practically pass a mutable PSBT, and instead need to pass an owned transaction and have the sign method return a signed copy. We do this here for all build modes as its not a material API change for Rust users.
This matches what we've done for other `[u8; 32]` newtypes.
`APeerManager` will simply be mapped as `PeerManager` in bindings, as structs are all concretized into a single form.
We missed one method that now cannot be bindings exported - the `payment_paths` method, as it returns a slice of objects, which cannot be supported in bindings.
The bindings are being updated to consider all traits even if the trait itself is no-export, which causes issues generating code around the `Duration` impl here.
While bindings should probably be able to figure out that this is the same type as `Self`, for now we simply swap the type to make the bindings generator have an easier go of it.
Notably including `Hash`/`Eq`/`Ord` for structs which may be used in maps.
TheBlueMatt
force-pushed
the
2023-07-116-bindings-part-2
branch
from
f23dbd1 to
27bf1d0
Compare
|
Merged the dependent PR so went ahead and rebased to remove the dependent commits. |
wpaulino
approved these changes
Jul 20, 2023
valentinewallace
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the remaining bindings-specific/-induced changes for 116, built on #2430.