Skip to content

Config-guard Event::InvoiceRequestFailed #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Sep 29, 2023

The event cannot be generated publicly, so remove it for now to avoid users needing to handle it.

@TheBlueMatt TheBlueMatt added this to the 0.0.117 milestone Sep 29, 2023
TheBlueMatt
TheBlueMatt previously approved these changes Sep 29, 2023
wpaulino
wpaulino previously approved these changes Sep 29, 2023
@wpaulino
Copy link
Contributor

Needs doc updates to not link to Event::InvoiceRequestFailed

@jkczyz jkczyz dismissed stale reviews from wpaulino and TheBlueMatt via 92e5cb6 September 29, 2023 22:03
@jkczyz jkczyz force-pushed the 2023-09-invreqfailed branch from dbafec7 to 92e5cb6 Compare September 29, 2023 22:03
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (955e810) 88.99% compared to head (92e5cb6) 89.69%.
Report is 12 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2629      +/-   ##
==========================================
+ Coverage   88.99%   89.69%   +0.70%     
==========================================
  Files         112      112              
  Lines       86510    89642    +3132     
  Branches    86510    89642    +3132     
==========================================
+ Hits        76986    80402    +3416     
+ Misses       7290     7029     -261     
+ Partials     2234     2211      -23     
Files Coverage Δ
lightning/src/events/mod.rs 30.45% <ø> (+0.64%) ⬆️
lightning/src/ln/channelmanager.rs 86.70% <100.00%> (+5.07%) ⬆️
lightning/src/ln/reload_tests.rs 96.24% <ø> (ø)
lightning/src/sign/type_resolver.rs 75.00% <ø> (ø)
lightning/src/ln/outbound_payment.rs 87.42% <75.00%> (-1.15%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit e0fe325 into lightningdevkit:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants