Skip to content

Remove log for not changing feerate when it was equal #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Oct 6, 2023

Log is not required in this case and creates unnecessary log lines at trace level.

Closes #2646

Log is not required in this case and creates unnecessary log lines at
trace level.
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9de51f0) 89.09% compared to head (2ee554a) 88.95%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
- Coverage   89.09%   88.95%   -0.15%     
==========================================
  Files         112      112              
  Lines       86959    87159     +200     
  Branches    86959    87159     +200     
==========================================
+ Hits        77476    77528      +52     
- Misses       7255     7391     +136     
- Partials     2228     2240      +12     
Files Coverage Δ
lightning/src/ln/channelmanager.rs 81.45% <66.66%> (-0.21%) ⬇️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valentinewallace valentinewallace merged commit 1f1a8dd into lightningdevkit:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LogRemove] : Channel {} does not qualify for a feerate change from 1637 to 1637.
4 participants