Skip to content

Marginally optimize test logging #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

TheBlueMatt
Copy link
Collaborator

973636b introduced a new HashMap in the TestLogger but then did lookups by iterating the entire map. This fixes that, and also takes this opportunity to stop allocating new Strings for the module to store each log entry in the TestLogger

973636b introduced a new `HashMap`
in the `TestLogger` but then did lookups by iterating the entire
map. This fixes that, and also takes this opportunity to stop
allocating new `String`s for the module to store each log entry in
the `TestLogger`
@TheBlueMatt TheBlueMatt force-pushed the 2023-12-2314-cleanups-2 branch from 41a75e3 to ec1a66e Compare December 2, 2023 19:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b43153) 88.64% compared to head (ec1a66e) 88.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2766      +/-   ##
==========================================
- Coverage   88.64%   88.63%   -0.01%     
==========================================
  Files         115      115              
  Lines       90257    90254       -3     
  Branches    90257    90254       -3     
==========================================
- Hits        80009    80000       -9     
- Misses       7842     7852      +10     
+ Partials     2406     2402       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull merged commit ac06a6a into lightningdevkit:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants