Marginally optimize test logging #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
973636b introduced a new `HashMap` in the `TestLogger` but then did lookups by iterating the entire map. This fixes that, and also takes this opportunity to stop allocating new `String`s for the module to store each log entry in the `TestLogger`
TheBlueMatt
force-pushed
the
2023-12-2314-cleanups-2
branch
from
41a75e3 to
ec1a66e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
==========================================
- Coverage 88.64% 88.63% -0.01%
==========================================
Files 115 115
Lines 90257 90254 -3
Branches 90257 90254 -3
==========================================
- Hits 80009 80000 -9
- Misses 7842 7852 +10
+ Partials 2406 2402 -4 ☔ View full report in Codecov by Sentry. |
jkczyz
approved these changes
Dec 2, 2023
tnull
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
973636b introduced a new
HashMapin theTestLoggerbut then did lookups by iterating the entire map. This fixes that, and also takes this opportunity to stop allocating newStrings for the module to store each log entry in theTestLogger