Post-#2314 Cleanups #3 #2769
Merged
Post-#2314 Cleanups #3 #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an important shutdown log being about a channel but not having the channel metadata.
There are various place where we log something related to a channel but fail to fill in the channel's counterparty information. This is somewhat surprising, given channel counterparty information is always known, but simply is sometimes not readily accessible to LDK when a log is printed.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
+ Coverage 88.64% 88.66% +0.01%
==========================================
Files 115 115
Lines 90257 90387 +130
Branches 90257 90387 +130
==========================================
+ Hits 80009 80140 +131
- Misses 7842 7847 +5
+ Partials 2406 2400 -6 ☔ View full report in Codecov by Sentry. |
shaavan
approved these changes
Dec 4, 2023
wpaulino
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various smaller cleanups left for #2314 that didn't fit into the other two PRs