Change WalletSource::sign_tx to sign_psbt

[benthecarman]

Closes #2713

Might want to add a test for taproot inputs to be extra sure, but the debug asserts I added should be sufficient

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcf47a4) 88.57% compared to head (7121290) 88.65%.
Report is 63 commits behind head on main.

❗ Current head 7121290 differs from pull request most recent head 489b408. Consider uploading reports for the commit 489b408 to get more accurate results

Files	Patch %	Lines
lightning/src/events/bump_transaction.rs	93.10%	0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
+ Coverage   88.57%   88.65%   +0.07%     
==========================================
  Files         115      115              
  Lines       90687    91188     +501     
  Branches    90687    91188     +501     
==========================================
+ Hits        80327    80841     +514     
+ Misses       7962     7922      -40     
- Partials     2398     2425      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wpaulino]

Thanks! Would appreciate if you could finish testing the anchors integration on your end and report back before landing this to make sure we're not missing anything else.

[TheBlueMatt]

I'm kinda meh on forcing users to use PSBTs here vs just having the option. I guess I don't really have a good feel for if "everything" has moved over to PSBTs yet, vs some stuff out there still using raw transactions during signing, but if not ISTM we should make this an option?

[benthecarman]

I'm kinda meh on forcing users to use PSBTs here vs just having the option. I guess I don't really have a good feel for if "everything" has moved over to PSBTs yet, vs some stuff out there still using raw transactions during signing, but if not ISTM we should make this an option?

It feels like everything has moved over to PSBT, but maybe I have a biased view, idk if any of the multi coin libraries support it

[wpaulino]

I'm kinda meh on forcing users to use PSBTs here vs just having the option. I guess I don't really have a good feel for if "everything" has moved over to PSBTs yet, vs some stuff out there still using raw transactions during signing, but if not ISTM we should make this an option?

They can still get the unsigned transaction out of it and sign it manually?

[TheBlueMatt]

Yea, I didn't realize initially that you could just extract_tx even on an unsigned tx.

[benthecarman]

I'll add that to the docs

[benthecarman]

Is there a compile error on master? The CI failure looks unrelated to this PR

[TheBlueMatt]

I think rust-bitcoin broke again :(

[TheBlueMatt]

Specifically, rust-bitcoin/rust-bitcoinconsensus#74 but we should just land this without waiting on that.