-
Notifications
You must be signed in to change notification settings - Fork 405
Have CI's cargo audit
ignore RUSTSEC-2021-0125
#2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have CI's cargo audit
ignore RUSTSEC-2021-0125
#2898
Conversation
WalkthroughThe update introduces an Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/audit.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/audit.yml
This advisory is only relevant for a downstream dependency of `criterion`, which we currently don't want to bump in order to continue benchmarking with our MSRV 1.63.0. We therefore just add it to our ignore list for now.
080aa59
to
9aa6ddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/audit.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/audit.yml
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
+ Coverage 89.11% 89.18% +0.06%
==========================================
Files 115 115
Lines 94232 94686 +454
Branches 94232 94686 +454
==========================================
+ Hits 83978 84442 +464
+ Misses 7781 7771 -10
Partials 2473 2473 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just an ignore + comment so no need to wait on another reviewer.
Closes #2896.
This advisory is only relevant for a downstream dependency of
criterion
, which we currently don't want to bump in order to continue benchmarking with our MSRV 1.63.0.We therefore just add it to our ignore list for now.