Skip to content

Add splicing feature flag #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Apr 18, 2024

Add splicing feature flag, also triggers dual_funding, as it's a prerequisite to splicing.

Change all dual_funding code to be gated by #[cfg(any(dual_funding, splicing))]
Change splicing code (few empty handler methods at this point) to be gated by #[cfg(splicing)]
LDK should work with both 'dual_funding' and 'splicing' flags (or both).

Housekeeping: may interfere with V2 PR #2302, but resolution should be straightforward.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (ac9a2c8) to head (8c334cb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
- Coverage   89.42%   89.41%   -0.02%     
==========================================
  Files         117      117              
  Lines       96290    96290              
  Branches    96290    96290              
==========================================
- Hits        86109    86097      -12     
- Misses       7962     7969       +7     
- Partials     2219     2224       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dunxen
Copy link
Contributor

dunxen commented Apr 18, 2024

Housekeeping: may interfere with V2 PR #2023, this may have to be deleted after that.

I don't think there will be any issues there. We'll still want to keep both flags around :)

@dunxen
Copy link
Contributor

dunxen commented Apr 18, 2024

LGTM. Is there anything else you'd like to change here or had concerns about?

@optout21 optout21 marked this pull request as ready for review April 18, 2024 14:26
@jkczyz
Copy link
Contributor

jkczyz commented Apr 18, 2024

Housekeeping: may interfere with V2 PR #2023, this may have to be deleted after that.

I don't think there will be any issues there. We'll still want to keep both flags around :)

Should that be #2302?

@jkczyz jkczyz merged commit 19dae8b into lightningdevkit:main Apr 18, 2024
16 checks passed
@optout21
Copy link
Contributor Author

Should that be #2302?

Of course, it was my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants