Two simple Channel cleanups #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably have happened when we moved most state into the state enums themselves, but specifically forcing awareness of the removed/not removed state would have prevented me from introducing a bug in the first version of an upcoming reserve-value patch.
TheBlueMatt
force-pushed
the
2019-03-chan-cleanup
branch
from
9b5d489 to
8d9b1af
Compare
This was referenced Mar 5, 2019
ariard
approved these changes
Mar 8, 2019
| /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but | ||
| /// the remote side hasn't yet revoked their previous state, which we need them to do before we | ||
| /// can do any backwards failing. Implies AwaitingRemoteRevoke. | ||
| /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a | ||
| /// revoke_and_ack to drop completely. | ||
| AwaitingRemovedRemoteRevoke, | ||
| AwaitingRemovedRemoteRevoke(Option<HTLCFailReason>), |
There was a problem hiding this comment.
Given that a state flag misuse has been and could be a likely source of errors, maybe we should have a more verbose name to dissociate AwaitingRemoteRevokeToRemote and AwaitingRemovedRemoteRevoke, like AwaitingRemoteRevokeToFinalDrop ? Had to read again their definition to get the slightly difference between them.
There was a problem hiding this comment.
Sure! That's somewhat orthogonal, though, so I'll leave that for a later cleanup, see #323.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.