-
Notifications
You must be signed in to change notification settings - Fork 406
Set max path length when paying BOLT 12 invoices. #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max path length when paying BOLT 12 invoices. #3156
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
==========================================
- Coverage 89.84% 89.80% -0.05%
==========================================
Files 121 121
Lines 99454 99526 +72
Branches 99454 99526 +72
==========================================
+ Hits 89357 89381 +24
- Misses 7498 7533 +35
- Partials 2599 2612 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question
7b88b80
to
678aac0
Compare
Squashed in nit with this diff: diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs
index a9fba2c56..443a7b2c3 100644
--- a/lightning/src/ln/outbound_payment.rs
+++ b/lightning/src/ln/outbound_payment.rs
@@ -510,7 +510,7 @@ pub enum Bolt12PaymentError {
UnexpectedInvoice,
/// Payment for an invoice with the corresponding [`PaymentId`] was already initiated.
DuplicateInvoice,
- /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion packet
+ /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion hop data
/// size of 1300 bytes.
///
/// [`BlindedPath`]: crate::blinded_path::BlindedPath |
Trivial fix with a test so I'm gonna land with 1 ACK |
This should've been done as part of #3026 but got overlooked.