Skip to content

Skip incremental-mutants job for main #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Skip incremental-mutants job for main #3158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d7829
Skip incremental-mutants job for main
dunxen Jul 4, 2024
8400cfc
Fix CI for unused `PendingOnionMessage`
dunxen Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ jobs:

incremental-mutants:
runs-on: ubuntu-latest
if: github.ref_name != 'main' # `main` has no diff with itself
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but would the 'real' solution be to check whether the diff is empty and always early-exit if so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it makes the expression a bit more complex and I had considered it. Or it requires an extra step before. I'll see how it can fit in this expression.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, don't bother if it's too much hassle I think, just wondered if we might into run similar cases where it wouldn't be main == main.

steps:
- uses: actions/checkout@v3
with:
Expand Down
1 change: 1 addition & 0 deletions lightning/src/onion_message/async_payments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use crate::io;
use crate::ln::msgs::DecodeError;
#[cfg(not(c_bindings))]
use crate::onion_message::messenger::PendingOnionMessage;
use crate::onion_message::messenger::{Responder, ResponseInstruction};
use crate::onion_message::packet::OnionMessageContents;
Expand Down
Loading