Skip to content

Fixes Sensei broken link #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

Harshit933
Copy link
Contributor

@Harshit933 Harshit933 commented Jul 9, 2024

Fixes broken link for Sensei lightning node.

Fixes: #3148

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (6035c83) to head (b93ec25).
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.02%     
==========================================
  Files         121      121              
  Lines       99858   100045     +187     
  Branches    99858   100045     +187     
==========================================
+ Hits        89622    89779     +157     
- Misses       7561     7588      +27     
- Partials     2675     2678       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given sensei is unintended, we should probably link to ldk-node (in a separate paragraph) and ldk-sample instead.

@Harshit933
Copy link
Contributor Author

Hello, sorry for being late, I missed my github notifications. Changed Sensei to LDK-sample and made another paragraph for LDK-node.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just docs so landing.

@TheBlueMatt TheBlueMatt merged commit 4bd4f19 into lightningdevkit:main Jul 15, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link to Sensei in the README is broken
4 participants