Return slices, rather than Vec references, in addresses
#3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its a bit strange to return a reference to a `Vec` in Rust, when a slice is really intended as the way to do so. Worse, the bindings don't know how to map a reference to a `Vec` (but do have code to map a slice of `Clone`able objects). Here, we move `NodeAnnouncementInfo::addresses` to return a slice, though to do so we have to adapt the `WithoutLength` `Writeable` impl to support slices as well.
TheBlueMatt
force-pushed
the
2024-08-ret-slice-not-ref-vec
branch
from
ffc88b0 to
b3aed9a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 89.78% 89.73% -0.06%
==========================================
Files 123 123
Lines 102330 102332 +2
Branches 102330 102332 +2
==========================================
- Hits 91876 91825 -51
- Misses 7763 7816 +53
Partials 2691 2691 ☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Aug 15, 2024
valentinewallace
merged commit 137cfea
into
lightningdevkit:main
18 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a bit strange to return a reference to a
Vecin Rust, when a slice is really intended as the way to do so. Worse, the bindings don't know how to map a reference to aVec(but do have code to map a slice ofCloneable objects).Here, we move
NodeAnnouncementInfo::addressesto return a slice, though to do so we have to adapt theWithoutLengthWriteableimpl to support slices as well.