Correct peer_handler::test_process_events_multithreaded
#3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
==========================================
+ Coverage 89.65% 90.23% +0.58%
==========================================
Files 125 125
Lines 102546 105713 +3167
Branches 102546 105713 +3167
==========================================
+ Hits 91936 95395 +3459
+ Misses 7904 7727 -177
+ Partials 2706 2591 -115 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2024-08-flaky-test
branch
from
36b4b7e to
9f3ca3d
Compare
| while start_time.elapsed() < Duration::from_millis(100) { | ||
| let val = cfg[0].chan_handler.message_fetch_counter.load(Ordering::Acquire); | ||
| assert!(val <= 2); | ||
| std::thread::yield_now(); // Winblowz seemingly doesn't ever interrupt threads?! |
There was a problem hiding this comment.
Do we still need this fix?
There was a problem hiding this comment.
No, none of the threads completely busy-loop now, they all sleep which should yield++.
This test was added some time ago in 0c034e9, but never made any sense. `PeerManager::process_events` will go around its loop as many times is required to ensure we've always processed all events which were pending prior to a `process_events` call, so having a test that checks that we never go around more than twice is obviously broken. And, indeed, in CI this tests fails with some regularity. Instead, the test here is changed to ensure that we detectably go around the loop again at least once. Fixes lightningdevkit#2385
TheBlueMatt
force-pushed
the
2024-08-flaky-test
branch
from
9f3ca3d to
e34519b
Compare
|
Squash-pushed with only the spelling change. |
valentinewallace
approved these changes
Aug 20, 2024
valentinewallace
merged commit b2cdc2c
into
lightningdevkit:main
18 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added some time ago in
0c034e9, but never made any sense.
PeerManager::process_eventswill go around its loop as many times is required to ensure we've always processed all events which were pending prior to aprocess_eventscall, so having a test that checks that we never go around more than twice is obviously broken.And, indeed, in CI this tests fails with some regularity.
Instead, the test here is changed to ensure that we detectably go around the loop again at least once.
Fixes #2385