Skip to content

Consistently pass DefaultRouter::new Default scoring parameters #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

In 26c1639 (and later in 50c55dc and
fb693ec) we switched to using Default::default() to initialize () for scoring parameters in tests. One ()s slipped back in recently, which we replace here.

In 26c1639 (and later in
50c55dc and
fb693ec) we switched to using
`Default::default()` to initialize `()` for scoring parameters in
tests. One `()`s slipped back in recently, which we replace here.
@TheBlueMatt TheBlueMatt added this to the 0.0.124 milestone Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (f89e963) to head (841e9de).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
- Coverage   89.72%   89.67%   -0.05%     
==========================================
  Files         125      125              
  Lines      102801   102801              
  Branches   102801   102801              
==========================================
- Hits        92234    92190      -44     
- Misses       7859     7896      +37     
- Partials     2708     2715       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit 3605777 into lightningdevkit:main Aug 20, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants