Skip to content

Use the actual type, not the associated type, in trait impls #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheBlueMatt
Copy link
Collaborator

This is equivalent and just easier for the bindings to deal with (though, really, they should handle it).

This is equivalent and just easier for the bindings to deal with
(though, really, they should handle it).
@TheBlueMatt TheBlueMatt added this to the 0.0.124 milestone Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (49dfa5a) to head (5359ceb).
Report is 4 commits behind head on main.

Files Patch % Lines
lightning/src/ln/peer_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
+ Coverage   89.79%   89.81%   +0.01%     
==========================================
  Files         125      126       +1     
  Lines      102810   103299     +489     
  Branches   102810   103299     +489     
==========================================
+ Hits        92322    92776     +454     
- Misses       7768     7805      +37     
+ Partials     2720     2718       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit 93c5bd1 into lightningdevkit:main Aug 23, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants