Gracefully handle fee-larger-than-claimed-value in ChannelMonitor #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in a full_stack_target failure as we overflow during subtraction otherwise. Instead, we try lower and lower fee estimator confirmation targets until we find one low enough, or discard the transaction. We should be able to handle this much cleaner, but for now this at least gets the fuzzer working again.
ariard
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Tested ACK 98134c8. Run fuzzer on it.
My bad, seems #334 was faulty.
Among cleaner solutions I see :
- have lower confirmation levels than Background
- aggregation triggering : have a buffer low_value_inputs_to_aggregate
- query a inputs pool from wallet to bump tx
|
Ehh, still better than it was. In the future, indeed, probably should come up with some metrics to ignore things when fees are high and go back and try them again if fees go back down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in a full_stack_target failure as we overflow during
subtraction otherwise.
Instead, we try lower and lower fee estimator confirmation targets
until we find one low enough, or discard the transaction. We should
be able to handle this much cleaner, but for now this at least gets
the fuzzer working again.