Skip to content

Misc updates to tee up async ChannelMonitorUpdate persist for claims against closed channels #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Misc updates to tee up async ChannelMonitorUpdate persist for claims against closed channels #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aba57bb
Make `test_durable_preimages_on_closed_channel` more robust
TheBlueMatt Nov 18, 2024
f9374b8
When removing `PeerState` check for in-flight mon updates deeply
TheBlueMatt Nov 14, 2024
d33687d
Don't generate dup force-close `ChannelMonitorUpdate`s on startup
TheBlueMatt Nov 18, 2024
385799f
Handle events immediately if we are running during block connection
TheBlueMatt Nov 18, 2024
d1c340a
Add additional variants to `handle_new_monitor_update!`
TheBlueMatt Nov 18, 2024
70a3751
Add monitor update handling to `update_maps_on_chan_removal`
TheBlueMatt Dec 5, 2024
4766e99
Properly enforce that all `ChannelMonitorUpdate`s are ordered
TheBlueMatt Nov 16, 2024
b50354d
Check in-flight updates before completing events on closed chans
TheBlueMatt Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lightning/src/chain/channelmonitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3150,8 +3150,11 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
panic!("Attempted to apply post-force-close ChannelMonitorUpdate that wasn't providing a payment preimage");
},
}
} else if self.latest_update_id + 1 != updates.update_id {
panic!("Attempted to apply ChannelMonitorUpdates out of order, check the update_id before passing an update to update_monitor!");
}
if updates.update_id != LEGACY_CLOSED_CHANNEL_UPDATE_ID {
if self.latest_update_id + 1 != updates.update_id {
panic!("Attempted to apply ChannelMonitorUpdates out of order, check the update_id before passing an update to update_monitor!");
}
}
let mut ret = Ok(());
let bounded_fee_estimator = LowerBoundedFeeEstimator::new(&**fee_estimator);
Expand Down
2 changes: 1 addition & 1 deletion lightning/src/ln/chanmon_update_fail_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,7 +3288,7 @@ fn do_test_durable_preimages_on_closed_channel(close_chans_before_reload: bool,
// Finally, check that B created a payment preimage transaction and close out the payment.
let bs_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
assert_eq!(bs_txn.len(), if close_chans_before_reload && !close_only_a { 2 } else { 1 });
let bs_preimage_tx = &bs_txn[0];
let bs_preimage_tx = bs_txn.iter().find(|tx| tx.input[0].previous_output.txid == as_closing_tx[0].compute_txid()).unwrap();
check_spends!(bs_preimage_tx, as_closing_tx[0]);

if !close_chans_before_reload {
Expand Down
Loading
Loading