Skip to content

Bump Engine : implement RBF for some timely channel transactions #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Bump Engine : implement RBF for some timely channel transactions #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b43e51f
Add MIN_RELAY_FEE_SAT_PER_1000_WEIGHT
Nov 19, 2019
742594a
Add log_trace on bump candidates tracking-buffer insertions
Jul 4, 2019
014f9b5
Move our_claim_txn_waiting_first_conf to pending_claim_requests
Jul 22, 2019
be619b5
Remove superflous pending_claims
Oct 25, 2019
84fdf07
Implement bumping engine in ChannelMonitor::block_connected
Jul 2, 2019
09890f3
Add RBF-bumping of preimage/timeout txn on remote HTLC outputs
Jul 3, 2019
7b93c48
Add test_bump_penalty_txn_on_revoked_commitment
Jul 2, 2019
5c179b2
Add test_bump_penalty_txn_on_revoked_htlcs
Dec 7, 2019
3cae707
Add test_bump_penalty_txn_on_remote_commitment
Dec 7, 2019
f8957c7
Track and react to remote partial-claiming of pending claim request
Dec 5, 2019
9284a2b
Add test_set_outpoints_partial_claiming
Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fuzz/fuzz_targets/full_stack_target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,8 @@ mod tests {
// I.e 2nd inbound read, len 18 : 0006 (encrypted message length) + 03000000000000000000000000000000 (MAC of the encrypted message length)
// Len 22 : 0010 00000000 (encrypted lightning message) + 03000000000000000000000000000000 (MAC of the Lightning message)

// Writing new code generating transactions and see a new failure ? Don't forget to add input for the FuzzEstimator !

// 0000000000000000000000000000000000000000000000000000000000000000 - our network key
// 00000000 - fee_proportional_millionths
// 01 - announce_channels_publicly
Expand Down Expand Up @@ -865,7 +867,9 @@ mod tests {
// 00fd - A feerate request (returning min feerate, which our open_channel also uses) (gonna be ingested by FuzzEstimator)
// 0c005e - connect a block with one transaction of len 94
// 0200000001fd00000000000000000000000000000000000000000000000000000000000000000000000000000000014f00000000000000220020f60000000000000000000000000000000000000000000000000000000000000000000000 - the funding transaction
// 00fd - A feerate request (returning min feerate, which our open_channel also uses) (gonna be ingested by FuzzEstimator)
// 0c0000 - connect a block with no transactions
// 00fd - A feerate request (returning min feerate, which our open_channel also uses) (gonna be ingested by FuzzEstimator)
// 0c0000 - connect a block with no transactions
// 0c0000 - connect a block with no transactions
// 0c0000 - connect a block with no transactions
Expand Down
3 changes: 3 additions & 0 deletions lightning/src/chain/chaininterface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ pub trait FeeEstimator: Sync + Send {
fn get_est_sat_per_1000_weight(&self, confirmation_target: ConfirmationTarget) -> u64;
}

/// Minimum relay fee as required by bitcoin network mempool policy.
pub const MIN_RELAY_FEE_SAT_PER_1000_WEIGHT: u64 = 4000;

/// Utility for tracking registered txn/outpoints and checking for matches
pub struct ChainWatchedUtil {
watch_all: bool,
Expand Down
Loading