Fix incremental relay constant name in docs #3565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morehouse
suggested changes
Jan 27, 2025
lightning/src/chain/package.rs
Outdated
Comment on lines
1243
to
1244
| /// fee and the corresponding updated feerate. If fee is under [`INCREMENTAL_RELAY_FEE_SAT_PER_1000_WEIGHT`], | ||
| /// we return nothing. |
There was a problem hiding this comment.
Except we should still use FEERATE_FLOOR_SATS_PER_KW here, since we're talking about the min feerate, not the incremental feerate.
Suggested change
| /// fee and the corresponding updated feerate. If fee is under [`INCREMENTAL_RELAY_FEE_SAT_PER_1000_WEIGHT`], | |
| /// we return nothing. | |
| /// fee and the corresponding updated feerate. If fee is under [`FEERATE_FLOOR_SATS_PER_KW`], | |
| /// we return nothing. | |
| /// | |
| /// [`FEERATE_FLOOR_SATS_PER_KW`]: crate::chain::chaininterface::FEERATE_FLOOR_SATS_PER_KW |
arik-so
force-pushed
the
min_relay_doc_fix
branch
from
13c1daf to
14c3479
Compare
TheBlueMatt
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial #3457 followup.