-
Notifications
You must be signed in to change notification settings - Fork 405
rustfmt
: Run on some smaller files in lightning/ln
#3724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wasn’t aware of rustfmt_excluded_files, I'm curious why it's needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
Because, sadly, rustfmt on some of our files creates some really unreadable results. So we're doing it iteratively, applying it to more and more files over time and removing things from the excluded list. |
d043a1a
to
8df643d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
+ Coverage 89.11% 89.50% +0.39%
==========================================
Files 156 156
Lines 123435 125924 +2489
Branches 123435 125924 +2489
==========================================
+ Hits 109995 112713 +2718
+ Misses 10758 10541 -217
+ Partials 2682 2670 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going ahead landing this with one ACK as it's trivial and the nit was addressed.
We run the formatter on some smallish files.