Test generated-route valididty in fuzzing #3728
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! This PR is now in draft status. |
TheBlueMatt
force-pushed
the
2025-04-route-valid-fuzz
branch
3 times, most recently
from
faa148e to
a364073
Compare
When routing, we have to assign a node counter for the recipient. When searching for a path to a blinded recipient, we do this by assigning a node counter to a NUMS pubkey. This should be fine as there is no known private key corresponding to this NUMS point, and thus no first-hop or network graph nodes can appear for the same pubkey. However, this can fail in fuzzing as the fuzzer can forge valid signatures for the NUMS pubkey. Thus, here, we adapt the node counter allocation to issue a node counter without a corresponding public key when paying to a blinded path.
While our router fuzzer is pretty good at hitting internal assertions in our pathfinder, it doesn't actually do anything to check that the returned route is valid (or meets the requirements given to the pathfinder). Here we add some initial checks covering the feerates of the hops taken in the returned route.
TheBlueMatt
force-pushed
the
2025-04-route-valid-fuzz
branch
from
a364073 to
908c5bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 157 157
Lines 123959 123968 +9
Branches 123959 123968 +9
=======================================
+ Hits 110485 110497 +12
- Misses 10791 10796 +5
+ Partials 2683 2675 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fails because of lightning/bolts#1249