Make generate_test_routes deterministic based on its seed
#3754
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @valentinewallace as a reviewer! |
The intent of `generate_test_routes` is to be deterministic based on a seed which is printed at the start. That way if a test fails, the seed can be trivially hard-coded and the test can be replicated. Sadly, it was not, as it used an iterator over an `IndexedMap` with key order randomization. Luckily, `IndexedMap` already supports sorted iteration, so we simply use it here.
TheBlueMatt
force-pushed
the
2025-04-deterministic-determinism
branch
from
b936eb3 to
6cef57b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3754 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 157 157
Lines 123959 123963 +4
Branches 123959 123963 +4
=======================================
+ Hits 110485 110491 +6
- Misses 10791 10796 +5
+ Partials 2683 2676 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinewallace
approved these changes
Apr 29, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
valentinewallace
merged commit 16307f6
into
lightningdevkit:main
27 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of
generate_test_routesis to be deterministic based on a seed which is printed at the start. That way if a test fails, the seed can be trivially hard-coded and the test can be replicated.Sadly, it was not, as it used an iterator over an
IndexedMapwith key order randomization. Luckily,IndexedMapalready supports sorted iteration, so we simply use it here.