Few more simple signer API additions #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
reviewed
Dec 13, 2019
| @@ -2665,14 +2665,16 @@ impl<ChanSigner: ChannelKeys> Channel<ChanSigner> { | |||
| let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000; | |||
|
|
|||
| let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false); | |||
| let funding_redeemscript = self.get_funding_redeemscript(); | |||
| let sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]); | |||
| let our_sig = self.local_keys | |||
There was a problem hiding this comment.
Something like if let Ok(our_sig) { Some() } else { None } would avoid conversion to option and calling unwrap. Would make code easier to review too.
There was a problem hiding this comment.
Ehh, I dont think so? map_err()? is pretty clear.
TheBlueMatt
force-pushed
the
2019-12-simple-signer-api-step
branch
from
15d6281 to
4ebe64f
Compare
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=========================================
+ Coverage 87.49% 87.5% +<.01%
=========================================
Files 30 30
Lines 16692 16733 +41
=========================================
+ Hits 14605 14642 +37
- Misses 2087 2091 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a big one coming up next, but this is easy so figured it can go first.
#408.