New API for ping generation #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
reviewed
Jan 5, 2020
lightning/src/ln/peer_handler.rs
Outdated
| @@ -115,6 +115,8 @@ struct Peer { | |||
| pending_read_is_header: bool, | |||
|
|
|||
| sync_status: InitSyncTracker, | |||
|
|
|||
| awaiting_pong: bool, | |||
There was a problem hiding this comment.
nit: You have a whitespace beginning of the line there ?
You can add exec git diff-index --check --cached $against -- in the default .git/hooks/pre-commit to avoid this in the future.
There was a problem hiding this comment.
sweet thanks, I will make a note of that.
I will go ahead and update it then rebase and push back
There was a problem hiding this comment.
I think I will see about making some changes to my text editor so it removes whitespace on the save as well.
Yeah I am using git diff and I can see the whitespaces :P
its kind of cool it highlights it in bright red on my command line (same w/ removing lines)
New API for generating pings
|
Okay when i run git diff it shows no whitespaces afaik :D |
TheBlueMatt
approved these changes
Jan 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweet, I think i got it fingers crossed :)
thanks for the help @TheBlueMatt @ariard I learned a lot.