Fix a bug in required feature checks #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2020-01-feature-sanity
branch
2 times, most recently
from
a0df021 to
6744119
Compare
TheBlueMatt
force-pushed
the
2020-01-feature-sanity
branch
2 times, most recently
from
f0fd817 to
18774bc
Compare
ariard
reviewed
Feb 12, 2020
This fixes the bitmask in requires_unknown_bits.
TheBlueMatt
force-pushed
the
2020-01-feature-sanity
branch
from
18774bc to
4ac9ed2
Compare
|
I believe I resolved the two concerns, @ariard . |
|
ACK 4ac9ed2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure we'll hit more such things when we do compat testing of the MPP stuff, but I think this one is Somewhat Obvious (tm), plus a few really trivial tests for features. When we do compat testing we should make sure to extract serialized features from other nodes and add those as tests. Based on the ongoing stack.