Score channels on payment (WIP) #625
Conversation
This caused a bunch of cascading changes, including passing loggers down to Channels in function calls rather than having each Channel have a pointer to the ChannelManager's Logger (which was a circular reference). Other structs that the Channel had passed its Logger to also had their loggers removed. Other newly unused Loggers were also removed, especially when keeping them would've caused a bunch of extra test changes to be necessary, e.g. with the ChainWatchInterfaceUtil's Logger.
Also adds a test for de/serializing events
Add fn signature for scoring payment
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
- Coverage 91.29% 91.23% -0.06%
==========================================
Files 35 35
Lines 20776 20792 +16
==========================================
+ Hits 18967 18970 +3
- Misses 1809 1822 +13
Continue to review full report at Codecov.
|
|
Looks like the current diff here includes a revert of #622? |
|
Cool! I just skimmed through the code, but I am curious if this scoring would be backed up in case the node restarts? I see in a comment the scoring data is stored in DirectionalChannelInfo ... is that data already included in a backup? |
…o score-channels-on-payment
…/rust-lightning into score-channels-on-payment
…/rust-lightning into score-channels-on-payment
sourabhmarathe
force-pushed
the
score-channels-on-payment
branch
from
700d8c8 to
20e3d70
Compare
Also adds a test for de/serializing events
Yes, it does. I think something went wrong with the timing of my the commits I had. I'm going to recreate this branch somewhere else and redo opening this draft PR in another location. |
I think because DirectionalChannelInfo implements serialization, it would make sense to do so for ChannelScore as well. I did implement the Readable and Writeable traits for ChannelScore, but there might be more that is needed to make the struct serializable. |
No description provided.