Code

(3/4) Conduit fixups from 494#693

Code

Closed

julianknutsen wants to merge 79 commits intolightningdevkit:mainlightningdevkit/rust-lightning:mainfrom

julianknutsen:conduit-fixupsjulianknutsen/rust-lightning:conduit-fixupsCopy head branch name to clipboard

Commits

Commits on Oct 2, 2020

• Squash changes from 494 into a single commit

  Show description for 244faa7
  

  julianknutsen

  and

  arik-so

  committed
  244faa7

  Copy full SHA for 244faa7

• Fix compilation bug in 494.

  Show description for ba37213
  julianknutsen

  committed
  ba37213

  Copy full SHA for ba37213

• tests: Add unit tests to handshake/mod.rs

  Show description for 98bc0da
  julianknutsen

  committed
  98bc0da

  Copy full SHA for 98bc0da

• delete: Remove duplicate tests

  julianknutsen

  committed
  52da509

  Copy full SHA for 52da509

• refactor: Create enum-dispatch NOISE state machine

  Show description for bfe6c4c
  julianknutsen

  committed
  bfe6c4c

  Copy full SHA for bfe6c4c

• refactor: Use new state machine in PeerHandshake

  Show description for c154f09
  julianknutsen

  committed
  c154f09

  Copy full SHA for c154f09

• refactor: Move helper functions to the states.rs

  julianknutsen

  committed
  9445fea

  Copy full SHA for 9445fea

• refactor: Structure initialize_state based on RFC

  Show description for a0d6690
  julianknutsen

  committed
  a0d6690

  Copy full SHA for a0d6690

• refactor: Structure calculate_act_message based on RFC

  Show description for a68af2d
  julianknutsen

  committed
  a68af2d

  Copy full SHA for a68af2d

• refactor: Structure process_act_message based on RFC

  Show description for abf9241
  julianknutsen

  committed
  abf9241

  Copy full SHA for abf9241

• refactor: Structure creation of Act3 based on RFC

  Show description for 3eb3146
  julianknutsen

  committed
  3eb3146

  Copy full SHA for 3eb3146

• refactor: Structure receiving of Act3 data based on RFC

  julianknutsen

  committed
  dbd1a21

  Copy full SHA for dbd1a21

• refactor: Inline single use constructors

  julianknutsen

  committed
  c88535a

  Copy full SHA for c88535a

• refactor: Pull public key generation to the initial states

  Show description for 41a8ac0
  julianknutsen

  committed
  41a8ac0

  Copy full SHA for 41a8ac0

• refactor: Remove HandshakeHash wrapper struct

  Show description for 8f17345
  julianknutsen

  committed
  8f17345

  Copy full SHA for 8f17345

• refactor: Combine duplicate code path for act1 and act2

  Show description for 988e767
  julianknutsen

  committed
  988e767

  Copy full SHA for 988e767

• refactor: Introduce ChainingKey type alias

  julianknutsen

  committed
  1e81642

  Copy full SHA for 1e81642

• refactor: Remove Act object

  Show description for de5a2e8
  julianknutsen

  committed
  de5a2e8

  Copy full SHA for de5a2e8

• refactor: Remove get_remote_pubkey interface

  Show description for e0a1e71
  julianknutsen

  committed
  e0a1e71

  Copy full SHA for e0a1e71

• refactor: Clean up process_peer_data

  Show description for 2f67eed
  julianknutsen

  committed
  2f67eed

  Copy full SHA for 2f67eed

• refactor: Doc and variable name cleanup in handshake/mod.rs

  Show description for ab4ff64
  julianknutsen

  committed
  ab4ff64

  Copy full SHA for ab4ff64

• tests: Finish testing handshake/mod.rs

  Show description for f29936b
  julianknutsen

  committed
  f29936b

  Copy full SHA for f29936b

• refactor: Clean up use of Sha256 in states.rs

  Show description for ab277b4
  julianknutsen

  committed
  ab277b4

  Copy full SHA for ab277b4

• refactor: Clean up hkdf::derive and add test

  Show description for 57f95fe
  julianknutsen

  committed
  57f95fe

  Copy full SHA for 57f95fe

• refactor: Rename Handshake2 and related structs/enums

  julianknutsen

  committed
  ea0ff51

  Copy full SHA for ea0ff51

• refactor: Clean up visibility/imports in handshake/

  Show description for 816a83c
  julianknutsen

  committed
  816a83c

  Copy full SHA for 816a83c

• tests: Leverage RFC test vectors in unit tests

  Show description for 9c5a4b7
  julianknutsen

  committed
  9c5a4b7

  Copy full SHA for 9c5a4b7

• refactor: Simplify logic for init message sending

  Show description for 3ae7604
  julianknutsen

  committed
  3ae7604

  Copy full SHA for 3ae7604

• refactor: Clean up unused variable warnings

  julianknutsen

  committed
  afd0334

  Copy full SHA for afd0334

• refactor: Hide empty next() requirement inside PeerHandshake

  Show description for ab2258c
  julianknutsen

  committed
  ab2258c

  Copy full SHA for ab2258c

• refactor: Remove unnecessary copy_from_slice calls in states.rs

  Show description for cc5cc9a
  julianknutsen

  committed
  cc5cc9a

  Copy full SHA for cc5cc9a

• tests: Add new fuzz testing for PeerHandshake

  Show description for b617dfa
  julianknutsen

  committed
  b617dfa

  Copy full SHA for b617dfa

• delete: Remove peer_channel_encryptor.rs

  Show description for 4435b12
  julianknutsen

  committed
  4435b12

  Copy full SHA for 4435b12

• fix: Allow partial act messages to be received

  Show description for a123f5e
  julianknutsen

  committed
  a123f5e

  Copy full SHA for a123f5e

• fix: Conduit::Decryptor should not panic on decryption failure

  Show description for 070d19b
  julianknutsen

  committed
  070d19b

  Copy full SHA for 070d19b

• test: Update handshake fuzz test to cover more cases

  Show description for 3a43c21
  julianknutsen

  committed
  3a43c21

  Copy full SHA for 3a43c21

• review: Split outbound initialization into new()/set_up()

  Show description for ec5803c
  julianknutsen

  committed
  ec5803c

  Copy full SHA for ec5803c

• feature: Tighten the constraints for act message sizes

  Show description for 1189e84
  julianknutsen

  committed
  1189e84

  Copy full SHA for 1189e84

• perf: Replace Vec w/ static arrays for act buffers

  Show description for 229c35f
  julianknutsen

  committed
  229c35f

  Copy full SHA for 229c35f

• perf: Remove Vec from chacha::encrypt/decrypt

  Show description for 753b517
  julianknutsen

  committed
  753b517

  Copy full SHA for 753b517

• review: Non-controversial renames, nits, small fixups

  Show description for a7a25ca
  julianknutsen

  committed
  a7a25ca

  Copy full SHA for a7a25ca

• review: rename hkdf -> hkdf5869rfc.rs

  Show description for b8136be
  julianknutsen

  committed
  b8136be

  Copy full SHA for b8136be

• review: Explicitly set version in Act creation

  Show description for 8c6da10
  julianknutsen

  committed
  8c6da10

  Copy full SHA for 8c6da10

• review: ActBuilder::fill() returns the number of bytes consumed

  Show description for 19a0f42
  julianknutsen

  committed
  19a0f42

  Copy full SHA for 19a0f42

• docs: Add license to new peers/ files

  julianknutsen

  committed
  30286c0

  Copy full SHA for 30286c0

• refactor: Abstract SocketDescriptor writing queue

  Show description for e4b8a59
  julianknutsen

  committed
  e4b8a59

  Copy full SHA for e4b8a59

• review: Move IHandshakeState code move to separate patch

  Show description for bf9edf3
  julianknutsen

  committed
  bf9edf3

  Copy full SHA for bf9edf3

• refactor: Abstract Transport layer and test it

  Show description for 8bdb638
  julianknutsen

  committed
  8bdb638

  Copy full SHA for 8bdb638

• rename: s/is_ready_for_encryption/is_connected/g

  julianknutsen

  committed
  62789ff

  Copy full SHA for 62789ff

• refactor: Move drain_messages() behind Transport

  julianknutsen

  committed
  d595445

  Copy full SHA for d595445

• refactor: remove duplicate assert

  julianknutsen

  committed
  22d3db2

  Copy full SHA for 22d3db2

• refactor: Move all enqueue logging to Transport

  julianknutsen

  committed
  05dc443

  Copy full SHA for 05dc443

• refactor: Make Transport the source of their_node_id

  Show description for a672649
  julianknutsen

  committed
  a672649

  Copy full SHA for a672649

• tests: Add unit tests for PeerManager

  Show description for ec07cbc
  julianknutsen

  committed
  ec07cbc

  Copy full SHA for ec07cbc

• refactor: Destructure read_event() path

  Show description for 3218522
  julianknutsen

  committed
  3218522

  Copy full SHA for 3218522

• fix: Fix reentrancy bug in read_event()

  Show description for b1ae365
  julianknutsen

  committed
  b1ae365

  Copy full SHA for b1ae365

• refactor: Continue constricting interfaces in message queue path

  Show description for 8ac0737
  julianknutsen

  committed
  8ac0737

  Copy full SHA for 8ac0737

• review: Move PayloadQueuer trait move to a separate commit

  Show description for 9de58d8
  julianknutsen

  committed
  9de58d8

  Copy full SHA for 9de58d8

• refactor: Clean up event handling path w.r.t connected state

  Show description for 3a9eb14
  julianknutsen

  committed
  3a9eb14

  Copy full SHA for 3a9eb14

• refactor: Introduce PostInitState

  Show description for 13b762b
  julianknutsen

  committed
  13b762b

  Copy full SHA for 13b762b

• fix: Don't allow peer_disconnect before peer_connected callbacks

  Show description for c44d42b
  julianknutsen

  committed
  c44d42b

  Copy full SHA for c44d42b

• refactor: Clean up the previously destructured read_event() path

  Show description for a5acccd
  julianknutsen

  committed
  a5acccd

  Copy full SHA for a5acccd

• refactor: Remove scoping from do_read_event()

  Show description for 0359955
  julianknutsen

  committed
  0359955

  Copy full SHA for 0359955

• refactor: Clean up the PeerHolder access/iteration/remove

  Show description for 51a3460
  julianknutsen

  committed
  51a3460

  Copy full SHA for 51a3460

• fix: Handle Ok(false) from route_handler callbacks in event path

  Show description for e5d6c2f
  julianknutsen

  committed
  e5d6c2f

  Copy full SHA for e5d6c2f

• fix: Use a separate lock for the ephemeral_key_midstate

  Show description for e316138
  julianknutsen

  committed
  e316138

  Copy full SHA for e316138

• rename: s/pending_outbound_buffer/outbound_queue/

  Show description for 8d5611c
  julianknutsen

  committed
  8d5611c

  Copy full SHA for 8d5611c

• Remove peers_needing_send set

  Show description for b618350
  julianknutsen

  committed
  b618350

  Copy full SHA for b618350

• review: Small nits, documentation, and fixups

  Show description for 4aababb
  julianknutsen

  committed
  4aababb

  Copy full SHA for 4aababb

• review: Catch duplicate connection after NOISE before INIT

  Show description for 93a70ce
  julianknutsen

  committed
  93a70ce

  Copy full SHA for 93a70ce

• review: Remove legacy (local/global) feature flag notation

  Show description for e5268bb
  julianknutsen

  committed
  e5268bb

  Copy full SHA for e5268bb

• review: Collapse OutboundQueue/Transport traits

  Show description for bf76e7c
  julianknutsen

  committed
  bf76e7c

  Copy full SHA for bf76e7c

• Move Conduit decryption into read()

  Show description for 3ab11f2
  julianknutsen

  committed
  3ab11f2

  Copy full SHA for 3ab11f2

• perf: Decryptor can now read from input slice when appropriate

  Show description for 2b8d24d
  julianknutsen

  committed
  2b8d24d

  Copy full SHA for 2b8d24d

• refactor: Use a real struct instead of conduit_and_remote_pubkey tuple

  Show description for d5573ed
  julianknutsen

  committed
  d5573ed

  Copy full SHA for d5573ed

• refactor: Make Conduit a simple wrapper

  Show description for 51da20d
  julianknutsen

  committed
  51da20d

  Copy full SHA for 51da20d

• refactor: Remove Conduit object

  Show description for 59728dc
  julianknutsen

  committed
  59728dc

  Copy full SHA for 59728dc

• refactor: Rename conduit.rs and clean up remaining references

  Show description for f4c76a9
  julianknutsen

  committed
  f4c76a9

  Copy full SHA for f4c76a9

• fix: Don't panic during valid decryption states

  Show description for 62820fe
  julianknutsen

  committed
  62820fe

  Copy full SHA for 62820fe