Update CI to run on Macos and Windows in addition to Ubuntu. #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Sep 17, 2020
Codecov Report
@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 36 36
Lines 20161 20161
=======================================
Hits 18531 18531
Misses 1630 1630
Continue to review full report at Codecov.
|
valentinewallace
force-pushed
the
cross-platform-ci
branch
2 times, most recently
from
2636c35 to
92bf617
Compare
|
This PR seems pretty self-contained, I think I'd prefer to do the bindings in a follow-up. |
valentinewallace
force-pushed
the
cross-platform-ci
branch
2 times, most recently
from
b784821 to
db144d9
Compare
…Ubuntu. We only run Macos and Windows on Rust stable, for efficient CI.
valentinewallace
force-pushed
the
cross-platform-ci
branch
from
db144d9 to
ce1f456
Compare
5 tasks
TheBlueMatt
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only run Macos and Windows on Rust stable, for efficient CI.
TODO: