Skip to content

Bindings Updates for #681 and more Clones #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 23, 2020
Merged

Bindings Updates for #681 and more Clones #749

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
304471b
[bindings] Support traits with generic arguments (to support #681)
TheBlueMatt Nov 13, 2020
90b668e
Update bindings demo for changes from #681 and the Persister trait
TheBlueMatt Nov 13, 2020
78b4598
[bindings] Make Transaction::data *mut instead of *const
TheBlueMatt Oct 9, 2020
336cb08
Update bindings demo for new Transaction::data mut-ness
TheBlueMatt Oct 9, 2020
faa8ec5
[bindings] Fix CVecTempl clone operation behavior.
TheBlueMatt Oct 20, 2020
29b209c
[bindings] Expose a _clone fn for every struct that derive(Clone)s
TheBlueMatt Oct 12, 2020
0362972
[bindings] Expose a _clone fn for every enum
TheBlueMatt Oct 20, 2020
d737111
derive(Clone) for several pub simple data structs.
TheBlueMatt Oct 20, 2020
d169966
[bindings] Update eq/clone trait fns to take object, not this_arg
TheBlueMatt Oct 26, 2020
66f46d4
Update bindings demo for new ChannelMonitor-update API
TheBlueMatt Nov 23, 2020
722a366
Update auto-generated bindings
TheBlueMatt Nov 13, 2020
9fe3124
Use CARGO_PROFILE_RELEASE_LTO to fix bindings build on new cargo
TheBlueMatt Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions c-bindings-gen/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,10 @@ fn writeln_enum<'a, 'b, W: std::io::Write>(w: &mut W, e: &'a syn::ItemEnum, type
if needs_free {
writeln!(w, "#[no_mangle]\npub extern \"C\" fn {}_free(this_ptr: {}) {{ }}", e.ident, e.ident).unwrap();
}
writeln!(w, "#[no_mangle]").unwrap();
writeln!(w, "pub extern \"C\" fn {}_clone(orig: &{}) -> {} {{", e.ident, e.ident, e.ident).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, it's fine that some pub(enum)s in RL don't implement Clone?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I mean I guess we should have them match, but its not an issue per se currently - if all the fields support Clone (as they would have to for the bindings crate to not fail to compile), then exposing a Clone to bindings seems fine.

writeln!(w, "\torig.clone()").unwrap();
writeln!(w, "}}").unwrap();
write_cpp_wrapper(cpp_headers, &format!("{}", e.ident), needs_free);
}

Expand Down