Skip to content

Call timer_tick_occurred in BackgroundProcessor #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valentinewallace
Copy link
Contributor

Forgot to add this in #864

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #872 (e5b99c1) into main (bc899dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          55       55           
  Lines       28912    28913    +1     
=======================================
+ Hits        26076    26078    +2     
+ Misses       2836     2835    -1     
Impacted Files Coverage Δ
lightning/src/ln/channel.rs 87.36% <ø> (ø)
background-processor/src/lib.rs 96.03% <100.00%> (+0.03%) ⬆️
lightning/src/ln/channelmanager.rs 83.00% <100.00%> (-0.05%) ⬇️
lightning/src/ln/functional_tests.rs 96.86% <100.00%> (+0.05%) ⬆️
lightning/src/util/events.rs 18.26% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc899dc...e5b99c1. Read the comment docs.

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK ca57087

@valentinewallace valentinewallace force-pushed the timer-tick-in-bg-processor branch from ca57087 to e5b99c1 Compare April 13, 2021 00:42
@TheBlueMatt
Copy link
Collaborator

Only diff (plus rebase) is addressing @ariard's comment, merging.

@TheBlueMatt TheBlueMatt merged commit 3d51b11 into lightningdevkit:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants