Require min_final_cltv_expiry in invoices #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
approved these changes
Apr 27, 2021
jkczyz
force-pushed
the
2021-04-invoice-expiry
branch
from
d76d56e to
58918c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
+ Coverage 90.39% 90.45% +0.06%
==========================================
Files 57 57
Lines 29500 29515 +15
==========================================
+ Hits 26666 26699 +33
+ Misses 2834 2816 -18
Continue to review full report at Codecov.
|
|
Needs (trivial) rebase. |
jkczyz
force-pushed
the
2021-04-invoice-expiry
branch
from
58918c7 to
aafa741
Compare
TheBlueMatt
approved these changes
Apr 29, 2021
|
ACK |
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightning invoices must be constructed with the
min_final_cltv_expiryfield set. For backwards compatibility, use a default value if not set.Fixes #879.