Skip to content

Return more error details on http's read_response #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

valentinewallace
Copy link
Contributor

Otherwise helpful error information gets swallowed.

Closes #877

@valentinewallace valentinewallace force-pushed the http-error-msgs branch 2 times, most recently from 8c5bb09 to 1d60fed Compare May 12, 2021 14:33
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #919 (4f880c6) into main (fcc0723) will decrease coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   90.50%   90.48%   -0.03%     
==========================================
  Files          59       59              
  Lines       29769    29788      +19     
==========================================
+ Hits        26942    26953      +11     
- Misses       2827     2835       +8     
Impacted Files Coverage Δ
lightning-block-sync/src/http.rs 95.11% <92.85%> (-0.27%) ⬇️
lightning-block-sync/src/rest.rs 67.24% <100.00%> (ø)
lightning-block-sync/src/rpc.rs 79.48% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 96.89% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc0723...4f880c6. Read the comment docs.

Otherwise helpful error information gets swallowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitcoind errors are swallowed
3 participants