Ignore messages with zlib-compressed fields #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #925 +/- ##
==========================================
- Coverage 90.45% 90.44% -0.01%
==========================================
Files 59 59
Lines 29785 29788 +3
==========================================
+ Hits 26941 26943 +2
- Misses 2844 2845 +1
Continue to review full report at Codecov.
|
valentinewallace
changed the title
TheBlueMatt
approved these changes
May 19, 2021
jkczyz
reviewed
May 20, 2021
No need to disconnect peers if this error is encountered. It just means we can't use some of their gossip messages.
if we receive a message with zlib-compressed values.
valentinewallace
force-pushed
the
ignore-zlib-compressed-msgs
branch
from
d3b308e to
9c344b7
Compare
TheBlueMatt
approved these changes
May 20, 2021
jkczyz
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this PR this would cause us to disconnect from CL peers. Seems to work in the sample.