replace use of bitcoin::utils::misc::hex_bytes with hex::decode

[savil]

as requested in #84 discussion
#84 (comment)

[TheBlueMatt]

Thanks! Also in fuzz/fuzz_targets. If you're gonna change every line anyway why not just write out "hex::decode"? Otherwise just import it as hex_bytes so you dont have to change every line.

[savil]

ah, yeah, forgot about fuzz directory. will do, hold on.

hmm - I guess, I was trying to match the existing code style of importing on top. I can change to ::hex::decode no problem.

Slight preference to avoid hex_bytes because then when reading code some files will say hex_decode/::hex::decode and some hex_bytes, and newbies will have to lookup the import line to realize they are the same things. Not a big deal, but a minor cognitive dissonance.

[savil]

in fuzz/, what did you have in mind? git grep "hex_bytes" has no results.

[TheBlueMatt]

In fuzz there's a bunch of extend_vec_from_hex's that could get replaced. import hex; and hex::decode seems good to me, or ::hex::decode, though I find that less readable.

[savil]

ah, got it (on both points).

…

On Fri, Jul 27, 2018 at 5:49 PM Matt Corallo ***@***.***> wrote: In fuzz there's a bunch of extend_vec_from_hex's that could get replaced. import hex; and hex::decode seems good to me, or ::hex::decode, though I find that less readable. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#95 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApSZNH3DeGNimdP8Xt-S0UIixmBCrWAks5uK7UpgaJpZM4Vk0QX> .

[savil]

fresh code is in. Lets hope it passes the travis/fuzz testing.

[TheBlueMatt]

I think usually its best to just specify 0.3, as minor bumps we'd want to take as bugfixes, no?

[savil]

fair point!