Skip to content

Drop the cdylib export of lightning-invoice #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

There are ~zero functions in lightning-invoice that are materially
callable from C, so there isn't any reason to tag it as a cdylib
(and make rustc build it as such). Instead, we have C bindings now.

There are ~zero functions in lightning-invoice that are materially
callable from C, so there isn't any reason to tag it as a cdylib
(and make rustc build it as such). Instead, we have C bindings now.
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #968 (b786adf) into main (bfd9646) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   90.65%   90.67%   +0.02%     
==========================================
  Files          60       60              
  Lines       30407    30407              
==========================================
+ Hits        27566    27573       +7     
+ Misses       2841     2834       -7     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 83.90% <0.00%> (+0.04%) ⬆️
lightning/src/ln/functional_tests.rs 97.22% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd9646...b786adf. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit ecddfe1 into lightningdevkit:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants