-
Notifications
You must be signed in to change notification settings - Fork 102
Prepare for release of v0.15.0-alpha.rc1 #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f6ce0e
to
d3ce7f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait! almost forgot - i think we need to please update the minimum LND version here to v0.19.0.
From the LiT side, this is so that in remote mode, we can be very sure that the LND node LiT is running with
has the latest RPC middleware updates that includes grpc Metadata as LiT now relies on this
Ah, I did that in the README but forgot to also bump it in the code. Will do that asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 🚀! Thanks a lot 🙏.
Leaving a few suggestions, especially around also updating the litrpc
package as well. If you'd prefer to do that in a separate PR and push a tag for that separately, let me know and I'll proceed to approve this :)
We bump all major dependencies to their respective latest versions.
Copy/paste made it that a variable name was incorrect, excluding and skipping each file.
Fixes several CVEs by using the latest Golang version to build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM 🎉!
No description provided.