[sql-40] firewalldb: action store prep commits #1078
Merged
+66
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our kvdb firewalldb, we use an empty 4 byte array as the macaroon identifier even if no macaroon was used to create the action. This is so that we have some sort of "session ID" bucket to store these set of actions under. For our SQL impl, however, this is not needed and we will likely just use a nullable field for the macaroon ID. So in preparation for this, we move the kvdb specific logic to the kvdb impl.
testTime1 should be before testTime2 otherwise it can lead to confusion.
Add a test covering a call to ListActions with group ID set and Reversed set and assert that the actions are returned in the correct order. This reveals a bug in the BoltDB implementation which was not making use of the query.Reversed parameter when group ID is set. NOTE: it still wont do pagination correctly (ie the pagination params still dont get used) but we at least here can easily let it use the Reversed param.
ellemouton
added
no-changelog
ViktorTigerstrom
approved these changes
May 28, 2025
| // macaroon ID. Otherwise, the last 4 bytes of the macaroon's root key | ||
| // ID are used. | ||
| var macaroonID [4]byte | ||
| var macaroonID fn.Option[[4]byte] |
There was a problem hiding this comment.
Thanks for this fix 🙏!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last couple of prep commits in the actions store. Just to limit the scope of the PR that follows (#1072 )
Part of #917