Skip to content

Add tooltips and toast alerts #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2020
Merged

Add tooltips and toast alerts #44

merged 5 commits into from
May 27, 2020

Conversation

jamaljsr
Copy link
Member

Closes #34

This PR adds tooltips and toast alerts to the UI.

image

image

To test tooltips, just hover your mouse over the history & export icons on the top right of the Loop page. There are other tooltip scattered throughout the app as well.

To test the toast alerts you will need to induce an error. The simplest way to do this is to stop your loopd node then refresh the page. You will see an error notification displayed on the top right of the screen. It will automatically disappear after 5 seconds.

@jamaljsr jamaljsr requested a review from guggero May 26, 2020 16:59
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Very nice that we now get errors in toast messages instead of the whole page disappearing!

@jamaljsr jamaljsr merged commit 5043c0b into master May 27, 2020
@jamaljsr jamaljsr deleted the tooltips-toasts branch May 27, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tooltips and Toasts
2 participants