-
Notifications
You must be signed in to change notification settings - Fork 2.2k
htlcswitch: merge htlc custom records on modify #9240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There isn't a good way to test this right now, because LND doesn't set any custom records - will be implicitly covered by the addition of #8390. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
37359cc
to
3bd3ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it
@carlaKC - might require a re-push to un-stick those last couple of itest. GH actions bug |
3bd3ae8
to
0e951b2
Compare
👍 rebased n pushed to kick actions |
I removed the |
0e951b2
to
54fa35b
Compare
whoops, TIL! |
54fa35b
to
151068c
Compare
Tests passed (with some known flakes), rebased to clear release notes conflict! |
Update forward interceptor
MODIFY
to consistently merge custom records supplied by the interceptor with those already in LND (previously it would overwrite if set and merge if empty).Note that this change does not provide the ability to clear any custom records (only overwrite them). If a use cases emerges for the ability to delete records, the API can be extended accordingly.
See #9166 for further discussion.