Skip to content

htlcswitch: merge htlc custom records on modify #9240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

carlaKC
Copy link
Collaborator

@carlaKC carlaKC commented Nov 1, 2024

Update forward interceptor MODIFY to consistently merge custom records supplied by the interceptor with those already in LND (previously it would overwrite if set and merge if empty).

Note that this change does not provide the ability to clear any custom records (only overwrite them). If a use cases emerges for the ability to delete records, the API can be extended accordingly.

See #9166 for further discussion.

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@carlaKC
Copy link
Collaborator Author

carlaKC commented Nov 1, 2024

There isn't a good way to test this right now, because LND doesn't set any custom records - will be implicitly covered by the addition of #8390.

@guggero guggero self-requested a review November 1, 2024 14:55
@carlaKC carlaKC changed the title htlcswitch: merge copy htlc custom records htlcswitch: merge htlc custom records on modify Nov 1, 2024
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero requested a review from ProofOfKeags November 4, 2024 10:16
@carlaKC carlaKC force-pushed the 9166-mergeonly branch 2 times, most recently from 37359cc to 3bd3ae8 Compare November 4, 2024 21:49
Copy link
Collaborator

@ProofOfKeags ProofOfKeags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@ellemouton
Copy link
Collaborator

@carlaKC - might require a re-push to un-stick those last couple of itest. GH actions bug

@carlaKC
Copy link
Collaborator Author

carlaKC commented Nov 7, 2024

@carlaKC - might require a re-push to un-stick those last couple of itest. GH actions bug

👍 rebased n pushed to kick actions

@guggero guggero removed the no-itest label Nov 7, 2024
@guggero
Copy link
Collaborator

guggero commented Nov 7, 2024

I removed the no-itest label to attempt to make them run (the label actually means "skip itests", not "it's okay this PR doesn't add any itests"), but a simple re-run of the actions didn't trigger them.
Would be good to make sure no itests are broken by this, so can you please do another change/rebase/push?

@carlaKC
Copy link
Collaborator Author

carlaKC commented Nov 7, 2024

the label actually means "skip itests", not "it's okay this PR doesn't add any itests"

whoops, TIL!

@carlaKC
Copy link
Collaborator Author

carlaKC commented Nov 7, 2024

Tests passed (with some known flakes), rebased to clear release notes conflict!

@ellemouton ellemouton merged commit 4430687 into lightningnetwork:master Nov 8, 2024
26 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants