Share underlying DOM global Window with the isolated World #583

sjorsdonkers · 2025-04-29T21:24:02Z

Only the main world page holds a HandleScope and an opened Context
Isolated Worlds do not hold a HandleScope and the Context is closed by default
An isolatedWorld context can only be made when there is a page
v8.context no longer live on the scope allowing the isolated world to be constructed after the page creation.

Note, we should probably:

rename Executor to World
rename Scope to Context
store the HandleScope in the SessionState
rename the createIsolatedWorld function to something similar to createPage, since the world already exists, adoptPage?, embracePage, assimilatePage? navigatePage, reset/reinitwithPage

[Feel free to merge if approved]

src/runtime/js.zig

share sessionstate and underlying DOM global with the isolated

7dde0be

sjorsdonkers requested a review from karlseguin April 29, 2025 21:24

karlseguin reviewed Apr 30, 2025

View reviewed changes

src/runtime/js.zig Outdated Show resolved Hide resolved

src/runtime/js.zig Show resolved Hide resolved

page handlescope clarification

83ef21e

karlseguin merged commit 27d1f79 into main Apr 30, 2025
12 checks passed

karlseguin deleted the share-state-and-global-with-the-isolated branch April 30, 2025 11:55

github-actions bot locked and limited conversation to collaborators Apr 30, 2025

Provide feedback