Skip to content

Laravel 11 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Laravel 11 #5

wants to merge 1 commit into from

Conversation

limenet
Copy link
Owner

@limenet limenet commented May 10, 2024

No description provided.

@limenet limenet self-assigned this May 10, 2024
@pelmered
Copy link

Hello @limenet.
Thanks for taking over this package!
How much do you have left to support Laravel 11? This is currently the only thing holding us back from upgrading.
Is there anything I can do to help?

@limenet
Copy link
Owner Author

limenet commented May 28, 2024

@pelmered appreciate your kind words and your offer.

While working on the upgrade, I realized there's a lot of work needed as this package relies on the now-removed Doctrine DBAL. There are also changes to the spatial types which I don't fully understand yet. And lastly, since the package was mostly "upgraded" to newer Laravel versions by bumping composer.json, some of the code (e.g. getting it to a decent PHPStan level) and CI needs some attention, too.

As casting support has become a lot stronger over the years, this feels like the direction I'd like to go and while doing some research I found https://github.com/MatanYadaev/laravel-eloquent-spatial which fit my use case for one project really well and migration was painless.

That being said, I yet have to upgrade another project to Laravel 11 (and that project is the main reason I started working on this project) so I might still resurrect the pull request.

What do you think, does https://github.com/MatanYadaev/laravel-eloquent-spatial fit your bill, too, or would you rather continue using this package?

@pelmered
Copy link

pelmered commented May 28, 2024

Yes, I did some research as well and MatanYadaev/laravel-eloquent-spatial has been on my radar for a while since the grimzy package seemed to be abandoned.

It also seems like Laravel gets a lot more support for spatial columns out of the box with Laravel 11. See this pull request for example. In some use cases you probably don't need a third party package anymore. This and MatanYadaev's package adds some more functionality that I think I need. I will try a migration and see how that works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants